fix off-by-one error that hid the eclipse achievement in the menu

doc/gamedesign.md

@@ -258,8 +258,8 @@ apart from the other characters. Let's outline the personalities/backstories:
     - Good for some small talk
     - Nerd about engineering, propulsion, rocket science
     - Rides a MeteorAceGT
-4. Sus @ pizzeria:
-    - A pig. ("Sus" is the genus of wild and domesticated pigs)
+4. Mudley @ pizzeria:
+    - A pig.
     - Can communicate via neural implants and space suit
     - Can manipulate the world through arms controlled by brain implants
     - Grew up on earth. Misses the mud.
@@ -324,7 +324,7 @@ Minor characters:
 - Nox [he]
 - Rudy [he]
 - Yuni [no pronoun]
-- Sus [he]
+- Mudley [he]
 - Ash [they]
 - River [she]
 - Rain [she]

src/chat.rs

@@ -26,8 +26,8 @@ pub const CHATS: &[&str] = &[
     include_str!("chats/thebe.yaml"),
 ];
 
-pub const CONTACTS: &[&str] = &["travel", "luna"];
-pub const CONTACTS_PRETTY: &[&str] = &["FASTravel", "Luna"];
+pub const CONTACTS: &[&str] = &["travel", "tinker", "pig"];
+pub const CONTACTS_PRETTY: &[&str] = &["FASTravel", "Luna", "Mudley"];
 pub const CONTACTS_UNKNOWN: &str = "[Unknown]";
 
 pub const TEXT_CONTINUE: &str = "Continue...";

src/chats/phone.yaml

@@ -18,11 +18,16 @@
   - sound: phone
     msg: Dialing...
   - goto: travel
-- if: phone$luna
+- if: phone$tinker
   Luna:
   - sound: phone
     msg: Dialing...
   - goto: luna
+- if: phone$pig
+  Mudley:
+  - sound: phone
+    msg: Dialing...
+  - goto: pig
 - "[Cancel]":
   - goto: EXIT
 
@@ -87,3 +92,38 @@
   - "[Hang up]": []
 - "[Hang up]": []
 - goto: EXIT
+
+# ---------------------------------------------------------
+# ---------------------------------------------------------
+# ---------------------------------------------------------
+
+- label: pig
+- script: changename Mudley
+- Heyyyy!! This is Mudley, what's up?
+- label: pig_node_main
+- Where are you hanging out?:
+  - I'm at the Old Eearth Pizzeria. Come over if you wanna hang!
+  - goto: pig_node_main
+- What's your story?:
+  - I'm a geologist.
+  - set: pig$geologist
+  - set: pig$earth
+  - I just loved the mud and dirt on Earth so much, I decided to study it.
+  - An endlessly fascinating subject.
+  - But the old rock, Earth, has been studied to the end and back.
+  - No scientific frontier in geology anymore.
+  - So I decided to venture into space, hoping to discover something novel.
+  - Came for the science, stayed for the floooooating around!
+  - I'm actually flying! Weeeeeeeee! This is so awesome!
+  - goto: pig_node_main
+- if: pig$earth
+  What do you miss most out here in space?:
+  - The mud!
+  - The space suit is quite liberating, with the comms and the appendages.
+  - But I miss being nude, wallowing in the mud.
+  - set: pig$mud
+  - So much dust and rocks out here and I can't touch any of it.
+  - It's driving me nuts!!! Aaaah!!
+  - goto: pig_node_main
+- "[Hang up]": []
+- goto: EXIT

src/chats/serenity.yaml

@@ -540,7 +540,7 @@
   - set: grateful 0
   - if $backupinstalled:
     - Of course, time traveler! Anything!
-    - script: registercontact luna
+    - script: registercontact tinker
     - goto: mainnode
   - if $believe:
     - Hm... I trust you, but... I want you to do me a favor first.
@@ -786,7 +786,7 @@
 ---
 
 
-- chat: Sus
+- chat: pig
 - if $helmet:
   - Come on, cave monkey, I can't give you the snack if you don't take off your helmet. [press ESC]
   - goto: EXIT
@@ -902,6 +902,14 @@
   - But the helmet is blocking your mouth, right?
   - So first, open the space suit menu [press ESC] and take off your helmet.
   - goto: EXIT
+- if: "~phone$pig"
+  Can I get your phone number?:
+  - if $annoyed:
+    - No.
+    - goto: entrypoint
+  - Sure, buddy!
+  - script: registercontact pig
+  - goto: entrypoint
 - Gotta go!:
   - Bye!
   - goto: EXIT

src/data/defs.txt

@@ -520,9 +520,9 @@ actor -3300 10 0 pizzeria
         actor 18 22 -15 sus
             template person
             relativeto pizzeriasign
-            name Sus
-            id Sus
-            chatid Sus
+            name Mudley
+            id Mudley
+            chatid pig
             angularmomentum 0.4 0.2 0.1
             wants maxrotation 0.2
             wants matchvelocitywith pizzeria

src/menu.rs

@@ -504,7 +504,7 @@ pub fn update_menu(
     let achievement_bools = achievement_tracker.to_bool_vec();
     let rendered = achievement_tracker.to_textsections();
     if let Ok(mut text) = q_achievement_text.get_single_mut() {
-        for i in 0..achievement_bools.len() - 1 {
+        for i in 0..achievement_bools.len() {
             text.sections[i + 1].style.color = if achievement_bools[i] {
                 settings.hud_color_achievement_accomplished
             } else {