pub-solar/infra
6
1
Fork 3
Code Issues 16 Pull requests 7 Actions Packages Projects 1 Releases Wiki Activity

style: avoid usage of top-level "with lib;" #195

Merged
teutat3s merged 1 commit from style-avoid-top-level-lib into main 2024-05-27 10:03:43 +00:00
Conversation 0 Commits 1 Files changed 4 +69 -57
teutat3s commented 2024-05-19 13:33:58 +00:00
Owner
Copy link

See: https://github.com/NixOS/nixpkgs/issues/208242. This is not strictly top-level usage of with lib;, more similar to the still allowed usage of meta = with lib; { ... };, but I'd like to get used to only getting required stuff into scope.

As a rule of thumb, I used inherit when an attribute from lib was required more than three times.

See: https://github.com/NixOS/nixpkgs/issues/208242. This is not strictly top-level usage of `with lib;`, more similar to the still allowed usage of `meta = with lib; { ... };`, but I'd like to get used to only getting required stuff into scope. As a rule of thumb, I used `inherit` when an attribute from `lib` was required more than three times.
teutat3s added 1 commit 2024-05-19 13:33:59 +00:00
style: avoid usage of top-level "with lib";
All checks were successful
Flake checks / Check (pull_request) Successful in 3m2s
Details
c015a1ec2e 
See: https://github.com/NixOS/nixpkgs/issues/208242
teutat3s changed title from style: avoid usage of top-level "with lib"; to style: avoid usage of top-level "with lib;" 2024-05-19 13:34:08 +00:00
teutat3s requested review from b12f 2024-05-23 09:58:03 +00:00
teutat3s requested review from hensoko 2024-05-23 09:58:03 +00:00
teutat3s requested review from axeman 2024-05-23 09:58:03 +00:00
hensoko approved these changes 2024-05-27 09:42:22 +00:00
teutat3s merged commit 1235a4f878 into main 2024-05-27 10:03:43 +00:00
teutat3s deleted branch style-avoid-top-level-lib 2024-05-27 10:03:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
b12f
axeman
hensoko
Labels
Clear labels   
Bug

   
Docs

   
Feature request

   
Good for newcomers

   
Infra

   
Privacy

   
Refactoring or migration

   
Security
No labels
Bug
Docs
Feature request
Good for newcomers
Infra
Privacy
Refactoring or migration
Security
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pub-solar/infra#195
No description provided.
Delete branch "style-avoid-top-level-lib"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?