pub-solar/infra
6
1
Fork 3
Code Issues 23 Pull requests 10 Actions Packages Projects 1 Releases Wiki Activity

fix(nextcloud): push server is not a trusted proxy #62

Merged
teutat3s merged 1 commit from fix/nextcloud-trusted-proxies into main 2023-11-18 22:12:50 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -5
teutat3s commented 2023-11-18 16:43:04 +00:00
Owner
Copy link

The nextcloud push service would fail with the following error message
when deploying a new version:

please add '2a01:4f8:172:1c25::1' to the list of trusted proxies or
configure any existing reverse proxy to forward the 'x-forwarded-for'
send by the push server
The following x-forwarded-for header was received by Nextcloud: 1.2.3.4
The following trusted proxies are currently configured: "127.0.0.1", "::1"

https://docs.nextcloud.com/server/stable/admin_manual/configuration_server/reverse_proxy_configuration.html#defining-trusted-proxies

The nextcloud push service would fail with the following error message when deploying a new version: ``` please add '2a01:4f8:172:1c25::1' to the list of trusted proxies or configure any existing reverse proxy to forward the 'x-forwarded-for' send by the push server The following x-forwarded-for header was received by Nextcloud: 1.2.3.4 The following trusted proxies are currently configured: "127.0.0.1", "::1" ``` https://docs.nextcloud.com/server/stable/admin_manual/configuration_server/reverse_proxy_configuration.html#defining-trusted-proxies
teutat3s force-pushed fix/nextcloud-trusted-proxies from b0c383cd2e to d26b3c12f4 2023-11-18 17:12:49 +00:00 Compare
b12f approved these changes 2023-11-18 21:33:57 +00:00
b12f reviewed 2023-11-18 21:34:26 +00:00
hosts/nachtigall/apps/nextcloud.nix
@ -50,4 +50,0 @@
trustedProxies = [
"127.0.0.1"
"::1"
];
b12f commented 2023-11-18 21:34:21 +00:00
Owner
Copy link

don't we still need this because we run nextcloud behind nginx?

don't we still need this because we run nextcloud behind nginx?
teutat3s commented 2023-11-18 21:44:14 +00:00
Author
Owner
Copy link

This option does it for us:
https://github.com/NixOS/nixpkgs/blob/nixos-23.05/nixos/modules/services/web-apps/nextcloud-notify_push.nix#L118-L120

This option does it for us: https://github.com/NixOS/nixpkgs/blob/nixos-23.05/nixos/modules/services/web-apps/nextcloud-notify_push.nix#L118-L120
teutat3s merged commit e41127593b into main 2023-11-18 22:12:50 +00:00
teutat3s deleted branch fix/nextcloud-trusted-proxies 2023-11-18 22:12:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
b12f
Labels
Clear labels   
Bug

   
Docs

   
Feature request

   
Good for newcomers

   
Infra

   
Privacy

   
Refactoring or migration

   
Security
No labels
Bug
Docs
Feature request
Good for newcomers
Infra
Privacy
Refactoring or migration
Security
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pub-solar/infra#62
No description provided.
Delete branch "fix/nextcloud-trusted-proxies"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?