pub-solar
/
os
5
0
Fork 2
Code Issues 9 Pull Requests Packages Projects 2 Releases Wiki Activity

Rework of x-os module / core profile #115

Merged
hensoko merged 0 commits from refs/pull/115/head into main 2022-08-14 13:13:27 +00:00
Conversation 0 Commits - Files Changed -
hensoko commented 2022-08-14 12:49:16 +00:00 (Migrated from git.b12f.io)
  • move core settings to x-os
  • add option to only install a lite core
  • rename x-os module to core
  • remove core profile from flake.nix
* move core settings to x-os * add option to only install a lite core * rename x-os module to core * remove core profile from flake.nix
b12f (Migrated from git.b12f.io) reviewed 2022-08-14 12:49:38 +00:00
teutat3s (Migrated from git.b12f.io) reviewed 2022-08-14 12:49:56 +00:00
b12f (Migrated from git.b12f.io) reviewed 2022-08-14 12:52:46 +00:00
modules/core/default.nix
@ -17,2 +18,4 @@
];
pub-solar.terminal-life.enable = true;
pub-solar.audio.enable = lib.mkIf (!cfg.lite) true;
b12f (Migrated from git.b12f.io) commented 2022-08-14 12:52:46 +00:00

I would just call this lite:

config.pub-solar.core.lite = true;
I would just call this `lite`: ``` config.pub-solar.core.lite = true; ```
modules/core/default.nix
@ -19,0 +21,4 @@
pub-solar.audio.enable = lib.mkIf (!cfg.lite) true;
pub-solar.crypto.enable = lib.mkIf (!cfg.lite) true;
pub-solar.devops.enable = lib.mkIf (!cfg.lite) true;
b12f (Migrated from git.b12f.io) commented 2022-08-14 12:52:57 +00:00

This description makes no sense

This description makes no sense
modules/core/modules.nix
b12f (Migrated from git.b12f.io) commented 2022-08-14 12:53:29 +00:00

I'd put all of these in core/default.nix directly under the option definition

I'd put all of these in `core/default.nix` directly under the option definition
modules/core/packages.nix
b12f (Migrated from git.b12f.io) commented 2022-08-14 12:54:20 +00:00

I'd argue this is core in 2022

I'd argue this is `core` in 2022
profiles/pub-solar-iso/default.nix
b12f (Migrated from git.b12f.io) commented 2022-08-14 12:57:02 +00:00

Let's also enable the lite core option for the iso

Let's also enable the `lite` core option for the iso
b12f (Migrated from git.b12f.io) commented 2022-08-14 12:57:02 +00:00

Let's also enable the lite core option for the iso

Let's also enable the `lite` core option for the iso
b12f (Migrated from git.b12f.io) approved these changes 2022-08-14 13:13:03 +00:00
b12f (Migrated from git.b12f.io) left a comment

LGTM

LGTM
Sign in to join this conversation.
Reviewers
No reviewers
teutat3s
b12f
Labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
enhancement

New feature   
help wanted

Need some help   
invalid

Something is wrong   
question

More information is needed   
wontfix

This won't be fixed
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: pub-solar/os#115
There is no content yet.
Delete Branch "refs/pull/115/head"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?