Update hakken times, add missing dependency #10

Merged
b12f merged 1 commit from hut/pub.solar:main into main 2023-06-23 14:14:46 +00:00
Contributor

2 changes in this PR:

  1. The direnv command was missing for me, but is listed in the instructions of the README, so I added it to the packages that are automatically installed with nix develop

  2. Updated the hakken dates & times to reflect Ben's proposal of 30th April

hakken.irl goes by the seasons. It will keep starting on the last friday of the month, but we'll have just four hakken.irl per year:

Winter hakken starts on the last friday of January
Spring hakken starts on the last friday of April
Summer hakken starts on the last friday of July
Autumn hakken starts on the last friday of October

hakken.irl starts Fridays at 13:12 officially, and ends Sundays at 16:20. The only hardcoded agenda point is cycling with Critical Mass.

If you want only 1 out of the 2 changes, I can make separate PRs. or just git cherry-pick :)

2 changes in this PR: 1. The `direnv` command was missing for me, but is listed in the instructions of the README, so I added it to the packages that are automatically installed with `nix develop` 2. Updated the hakken dates & times to reflect Ben's proposal of 30th April > hakken.irl goes by the seasons. It will keep starting on the last friday of the month, but we'll have just four hakken.irl per year: > > Winter hakken starts on the last friday of January > Spring hakken starts on the last friday of April > Summer hakken starts on the last friday of July > Autumn hakken starts on the last friday of October > > hakken.irl starts Fridays at 13:12 officially, and ends Sundays at 16:20. The only hardcoded agenda point is cycling with Critical Mass. If you want only 1 out of the 2 changes, I can make separate PRs. or just `git cherry-pick` :)
hut added 2 commits 2023-06-19 22:44:07 +00:00
update hakken dates & times
All checks were successful
continuous-integration/drone/pr Build is passing
3c5f26d203
Owner

Thank you very much for this! 💙

Regarding direnv, that is most useful when you have it installed globally on your system. It basically runs nix develop for you, once you enter a directory which contains a .envrc file and allow it by running direnv allow.
EDIT: The ReadMe could be improved to clarify this, e.g. just run nix develop to start working on this, but if you have direnv installed globally, you can also run direnv allow.

I'd propose to remove commit 9bb0b6253a from this PR.

The changes in JavaScript look good to me.
Would prefer to have @b12f take a look at those changes, too.

Thank you very much for this! 💙 Regarding `direnv`, that is most useful when you have it installed globally on your system. It basically runs `nix develop` for you, once you enter a directory which contains a `.envrc` file and allow it by running `direnv allow`. EDIT: The ReadMe could be improved to clarify this, e.g. just run `nix develop` to start working on this, but if you have `direnv` installed globally, you can also run `direnv allow`. I'd propose to remove commit 9bb0b6253a from this PR. The changes in JavaScript look good to me. Would prefer to have @b12f take a look at those changes, too.
hut force-pushed main from 3c5f26d203 to e8f616b538 2023-06-20 11:36:09 +00:00 Compare
Author
Contributor

Thanks for the clarification on direnv. I took it out of the PR.

Thanks for the clarification on `direnv`. I took it out of the PR.
teutat3s approved these changes 2023-06-22 07:54:40 +00:00
teutat3s left a comment
Owner

LGTM, pending review from @b12f

LGTM, pending review from @b12f
Owner

LGTM, thanks a lot for the work!

LGTM, thanks a lot for the work!
b12f merged commit 81ab1e01fa into main 2023-06-23 14:14:46 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pub-solar/pub.solar#10
No description provided.